Messages in this thread | | | Date | Tue, 24 Feb 2015 07:15:00 +0100 | From | Juergen Gross <> | Subject | Re: [Xen-devel] [PATCH 05/13] xen: simplify xen_set_identity_and_remap() by using global variables |
| |
On 02/19/2015 07:10 PM, David Vrabel wrote: > > > On 18/02/2015 06:51, Juergen Gross wrote: >> xen_set_identity_and_remap() is used to prepare remapping of memory >> conflicting with the E820 map. It is tracking the pfn where to remap >> new memory via a local variable which is passed to a subfunction >> which in turn returns the new value for that variable. >> >> Additionally the targeted maximum pfn is passed as a parameter to >> sub functions. >> >> Simplify that construct by using just global variables in the >> source for that purpose. This will make things simpler when we need >> those values later, too. > > I'm not convinced this actually simplifies anything.
Perhaps I should have emphasised the last sentence a bit more. I really need the global variables when deferring the remap operation.
Juergen
| |