Messages in this thread | | | Subject | Re: [PATCH 7/7] thinkpad_acpi: use DEVICE_ATTR_* macros | From | Bastien Nocera <> | Date | Mon, 23 Feb 2015 11:27:34 +0100 |
| |
On Mon, 2015-02-23 at 07:25 -0300, Henrique de Moraes Holschuh wrote: > On Fri, Feb 20, 2015, at 11:44, Bastien Nocera wrote: > > Use the DEVICE_ATTR_RW macro to reduce boiler plate > > So far, so good, but you also used the DEVICE_ATTR_RO macro... > > > and move the attribute declaration to get rid of function signatures. > > I didn't see any "move the attribute declaration" done in this patch.
Too much cut'n'paste from another similar patch. I'll resend with a better commit message.
> Other than that, looks good.
Great, thanks.
| |