lkml.org 
[lkml]   [2015]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 7/7] thinkpad_acpi: use DEVICE_ATTR_* macros
From
Date
On Mon, 2015-02-23 at 07:25 -0300, Henrique de Moraes Holschuh wrote:
> On Fri, Feb 20, 2015, at 11:44, Bastien Nocera wrote:
> > Use the DEVICE_ATTR_RW macro to reduce boiler plate
>
> So far, so good, but you also used the DEVICE_ATTR_RO macro...
>
> > and move the attribute declaration to get rid of function signatures.
>
> I didn't see any "move the attribute declaration" done in this patch.

Too much cut'n'paste from another similar patch. I'll resend with a
better commit message.

> Other than that, looks good.

Great, thanks.



\
 
 \ /
  Last update: 2015-02-23 11:41    [W:0.111 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site