Messages in this thread | | | Date | Mon, 23 Feb 2015 12:54:04 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 06/27] power: wakeup: Remove use of seq_printf return value |
| |
On Sun 2015-02-22 13:52:58, Joe Perches wrote: > On Sun, 2015-02-22 at 22:38 +0100, Pavel Machek wrote: > > On Sat 2015-02-21 18:53:33, Joe Perches wrote: > > > The seq_printf return value, because it's frequently misused, > > > will eventually be converted to void. > > > > > > See: commit 1f33c41c03da ("seq_file: Rename seq_overflow() to > > > seq_has_overflowed() and make public") > > > > You've just removed overflow handling from > > print_wakeup_source_stats. > > > > Can you explain why that is good idea? > > If overflow occurs, the seq_file subsystem allocates > a bigger buffer and calls the show function again. > > See Al's comment in the 0/n patch and here: > https://lkml.org/lkml/2015/2/17/642
You may want to explain while this is good idea in the changelog.
From your explanation it looks like error is somehow handled on higher-level retry, but...
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |