lkml.org 
[lkml]   [2015]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 06/27] power: wakeup: Remove use of seq_printf return value
    On Sat 2015-02-21 18:53:33, Joe Perches wrote:
    > The seq_printf return value, because it's frequently misused,
    > will eventually be converted to void.
    >
    > See: commit 1f33c41c03da ("seq_file: Rename seq_overflow() to
    > seq_has_overflowed() and make public")

    You've just removed overflow handling from
    print_wakeup_source_stats. Can you explain why that is good idea?

    Pavel

    > --- a/drivers/base/power/wakeup.c
    > +++ b/drivers/base/power/wakeup.c
    > @@ -842,7 +842,6 @@ static int print_wakeup_source_stats(struct seq_file *m,
    > unsigned long active_count;
    > ktime_t active_time;
    > ktime_t prevent_sleep_time;
    > - int ret;
    >
    > spin_lock_irqsave(&ws->lock, flags);
    >
    > @@ -865,17 +864,16 @@ static int print_wakeup_source_stats(struct seq_file *m,
    > active_time = ktime_set(0, 0);
    > }
    >
    > - ret = seq_printf(m, "%-12s\t%lu\t\t%lu\t\t%lu\t\t%lu\t\t"
    > - "%lld\t\t%lld\t\t%lld\t\t%lld\t\t%lld\n",
    > - ws->name, active_count, ws->event_count,
    > - ws->wakeup_count, ws->expire_count,
    > - ktime_to_ms(active_time), ktime_to_ms(total_time),
    > - ktime_to_ms(max_time), ktime_to_ms(ws->last_time),
    > - ktime_to_ms(prevent_sleep_time));
    > + seq_printf(m, "%-12s\t%lu\t\t%lu\t\t%lu\t\t%lu\t\t%lld\t\t%lld\t\t%lld\t\t%lld\t\t%lld\n",
    > + ws->name, active_count, ws->event_count,
    > + ws->wakeup_count, ws->expire_count,
    > + ktime_to_ms(active_time), ktime_to_ms(total_time),
    > + ktime_to_ms(max_time), ktime_to_ms(ws->last_time),
    > + ktime_to_ms(prevent_sleep_time));
    >
    > spin_unlock_irqrestore(&ws->lock, flags);
    >
    > - return ret;
    > + return 0;

    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


    \
     
     \ /
      Last update: 2015-02-22 23:01    [W:4.483 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site