lkml.org 
[lkml]   [2015]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ARM: bcm2835: Add header file for pinctrl constants
On Sun, Feb 22, 2015 at 09:13:23PM +0100, Arnd Bergmann wrote:
> On Sunday 22 February 2015 16:59:56 Charles Keepax wrote:
> > +
> > +/* IRQ Flags */
> > +#define BCM2835_PIN_IRQ_RISING 1
> > +#define BCM2835_PIN_IRQ_FALLING 2
> > +#define BCM2835_PIN_IRQ_EDGE (BCM2835_PIN_IRQ_RISING | \
> > + BCM2835_PIN_IRQ_FALLING)
> > +#define BCM2835_PIN_IRQ_LOW 4
> > +#define BCM2835_PIN_IRQ_HIGH 8
>
> Are these different from the standard definitions?
>
> > +/* Pin Function Settings */
> > +#define BCM2835_PIN_FUNC_GPIO_IN 0
> > +#define BCM2835_PIN_FUNC_GPIO_OUT 1
> > +#define BCM2835_PIN_FUNC_ALT5 2
> > +#define BCM2835_PIN_FUNC_ALT4 3
> > +#define BCM2835_PIN_FUNC_ALT0 4
> > +#define BCM2835_PIN_FUNC_ALT1 5
> > +#define BCM2835_PIN_FUNC_ALT2 6
> > +#define BCM2835_PIN_FUNC_ALT3 7
>
> Why are these required? They don't seem to be used by any driver,
> which leads me to suspect that they are just the hardware numbers.
>
> In that case, don't add any syntactical sugar like that and just
> use the hardware numbers directly.

Yeah they are just hardware numbers, I wasn't aware there was a
preference to use the numbers directly in which case just ignore
this patch.

>
> What's with the strange mapping of numbers anyway?

You would need to ask Broadcom that :-)

Thanks,
Charles


\
 
 \ /
  Last update: 2015-02-22 22:41    [W:0.047 / U:0.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site