Messages in this thread | | | Date | Sun, 22 Feb 2015 16:28:05 -0500 | From | Sasha Levin <> | Subject | Re: [PATCH] rhashtable: initialize all rhashtable walker members |
| |
On 02/22/2015 03:58 PM, David Miller wrote: > From: Sasha Levin <sasha.levin@oracle.com> > Date: Sat, 21 Feb 2015 15:55:11 -0500 > >> Commit "rhashtable: Introduce rhashtable_walk_*" forgot to initialize the >> members of struct rhashtable_walker after allocating it, which caused >> an undefined value for 'resize' which is used later on. >> >> Signed-off-by: Sasha Levin <sasha.levin@oracle.com> > > Commits should be referred to by SHA1 ID as well as the commit > header text (in parenthesis and double quotes).
It wasn't (isn't?) in Linus' tree yet, so I didn't want to refer to it by a SHA1 ID which would change.
> Even better, refer to the commit using a "Fixes: " tag right before > your signoff.
Ok, should I resend?
Thanks, Sasha
| |