lkml.org 
[lkml]   [2015]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 24/27] tracing: Remove use of seq_printf return value
    On Sat, 21 Feb 2015 18:53:51 -0800
    Joe Perches <joe@perches.com> wrote:

    > The seq_printf return value, because it's frequently misused,
    > will eventually be converted to void.
    >
    > See: commit 1f33c41c03da ("seq_file: Rename seq_overflow() to
    > seq_has_overflowed() and make public")
    >
    > Miscellanea:
    >
    > o Remove unused return value from trace_lookup_stack

    Acked-by: Steven Rostedt <rostedt@goodmis.org>

    -- Steve

    >
    > Signed-off-by: Joe Perches <joe@perches.com>
    > ---
    > kernel/trace/trace_stack.c | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/kernel/trace/trace_stack.c b/kernel/trace/trace_stack.c
    > index c3e4fcf..3f34496 100644
    > --- a/kernel/trace/trace_stack.c
    > +++ b/kernel/trace/trace_stack.c
    > @@ -327,11 +327,11 @@ static void t_stop(struct seq_file *m, void *p)
    > local_irq_enable();
    > }
    >
    > -static int trace_lookup_stack(struct seq_file *m, long i)
    > +static void trace_lookup_stack(struct seq_file *m, long i)
    > {
    > unsigned long addr = stack_dump_trace[i];
    >
    > - return seq_printf(m, "%pS\n", (void *)addr);
    > + seq_printf(m, "%pS\n", (void *)addr);
    > }
    >
    > static void print_disabled(struct seq_file *m)



    \
     
     \ /
      Last update: 2015-02-22 05:01    [W:4.248 / U:1.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site