lkml.org 
[lkml]   [2015]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 05/27] x86: mtrr: if: Remove use of seq_printf return value
    Date
    The seq_printf return value, because it's frequently misused,
    will eventually be converted to void.

    See: commit 1f33c41c03da ("seq_file: Rename seq_overflow() to
    seq_has_overflowed() and make public")

    Signed-off-by: Joe Perches <joe@perches.com>
    ---
    arch/x86/kernel/cpu/mtrr/if.c | 12 +++++-------
    1 file changed, 5 insertions(+), 7 deletions(-)

    diff --git a/arch/x86/kernel/cpu/mtrr/if.c b/arch/x86/kernel/cpu/mtrr/if.c
    index a041e09..d76f13d 100644
    --- a/arch/x86/kernel/cpu/mtrr/if.c
    +++ b/arch/x86/kernel/cpu/mtrr/if.c
    @@ -404,11 +404,10 @@ static const struct file_operations mtrr_fops = {
    static int mtrr_seq_show(struct seq_file *seq, void *offset)
    {
    char factor;
    - int i, max, len;
    + int i, max;
    mtrr_type type;
    unsigned long base, size;

    - len = 0;
    max = num_var_ranges;
    for (i = 0; i < max; i++) {
    mtrr_if->get(i, &base, &size, &type);
    @@ -425,11 +424,10 @@ static int mtrr_seq_show(struct seq_file *seq, void *offset)
    size >>= 20 - PAGE_SHIFT;
    }
    /* Base can be > 32bit */
    - len += seq_printf(seq, "reg%02i: base=0x%06lx000 "
    - "(%5luMB), size=%5lu%cB, count=%d: %s\n",
    - i, base, base >> (20 - PAGE_SHIFT), size,
    - factor, mtrr_usage_table[i],
    - mtrr_attrib_to_str(type));
    + seq_printf(seq, "reg%02i: base=0x%06lx000 (%5luMB), size=%5lu%cB, count=%d: %s\n",
    + i, base, base >> (20 - PAGE_SHIFT),
    + size, factor,
    + mtrr_usage_table[i], mtrr_attrib_to_str(type));
    }
    return 0;
    }
    --
    2.1.2


    \
     
     \ /
      Last update: 2015-02-22 04:01    [W:2.223 / U:0.616 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site