lkml.org 
[lkml]   [2015]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/7 linux-next] wan: cosa: replace current->state by set_current_state()


> On 20 February 2015 at 19:58 Peter Zijlstra <peterz@infradead.org> wrote:
>
>
> On Fri, Feb 20, 2015 at 09:34:28PM +0300, Sergei Shtylyov wrote:
> > Hello.
> >
> > On 02/20/2015 09:12 PM, Fabian Frederick wrote:
> >
> > >Use helper functions to access current->state.
> > >Direct assignments are prone to races and therefore buggy.
> >
> > >current->state = TASK_RUNNING is replaced by __set_current_state()
> >
> >    You sometimes use __set_current_state() and sometimes
> >set_current_state().
>
> It depends on which state; setting yourself TASK_RUNNING is free of
> wakeup races -- you're already running after all, so it can safely use
> __set_current_state().
>
> Setting a blocking state otoh needs set_current_state() which issues a
> full memory barriers with the store (critically in this case,
> effectively after the store) such that it orders the state store with a
> subsequent load in the condition check if it really needs to go to
> sleep.
>
>
> In full:
>
>       current->state = TASK_UNINTERRUPTIBLE;          wait = false;
>       smp_mb();                                       smp_wmb();
>       if (wait)                                       p->state = TASK_RUNNING;
>               schedule();
>
> Without that smp_mb(); the following order is possible:
>
>       if (wait)
>                                                       wait = false;
>                                                       smp_wmb();
>                                                       p->state = TASK_RUNNING;
>       current->state = TASK_UNINTERRUPTIBLE;
>               schedule();
>
> And we'll wait forever more..
Do I have to add more comments in changelogs or is it OK for you ?
Maybe something like:
"
current->state = TASK_RUNNING can safely be converted to __set_current_state()
as we're already in that state. Other assignments are converted to
set_current_state() (which uses set_mb()).

"
Regards,
Fabian
>


\
 
 \ /
  Last update: 2015-02-21 09:01    [W:0.064 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site