lkml.org 
[lkml]   [2015]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 4/4] Staging: rtl8192u: r819xU_firmware: added space after comma
From
On Fri, Feb 20, 2015 at 11:47 AM, Tolga Ceylan <tolga.ceylan@gmail.com> wrote:
> On Thu, Feb 19, 2015 at 11:30 PM, Joe Perches <joe@perches.com> wrote:
>>
>> Might as well remove the unnecessary cast too:
>>
>> memcpy(skb->cb, &dev, sizeof(dev));
>>
>> but it might be better to avoid the memcpy and use an assign
>>
>> *(struct net_device *)skb->cb = dev;
>>
>

Should I sent a new set of patches (including memcpy change)?
Or reply to the series with a single memcpy change patch?


\
 
 \ /
  Last update: 2015-02-21 01:41    [W:0.063 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site