Messages in this thread | | | Date | Fri, 20 Feb 2015 16:23:08 -0500 (EST) | Subject | Re: [PATCH] net: smc91x: improve neponset hack | From | David Miller <> |
| |
From: Arnd Bergmann <arnd@arndb.de> Date: Fri, 20 Feb 2015 16:47:06 +0100
> On Thursday 19 February 2015 00:35:49 Russell King - ARM Linux wrote: >> On Wed, Feb 18, 2015 at 08:47:30PM +0100, Arnd Bergmann wrote: >> > The smc91x driver tries to support multiple platforms at compile >> > time, but they are mutually exclusive at runtime, and not clearly >> > defined. >> >> I'd prefer to rework this to fix that properly. From what I remember, >> the whole SA11x0 stuff in this driver was a mess. > > I guess that's reasonable. I've looked through the driver and it seems we > did most of the multiplatform work but left a few things alone that should > have been converted a long time ago. > > Can you check if the approach below makes sense to you? > > I've verified that each machine that defines an smc91x device now sets > the correct platform data, irq flags and access width, which should be > enough to collapse all the CONFIG_ARM cases into one. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This is a nice cleanup but for 'net' to fix the build error I prefer the original one-line patch.
We can apply this thing here to net-next.
| |