Messages in this thread | | | Date | Fri, 20 Feb 2015 15:50:08 -0500 (EST) | Subject | Re: [PATCH] net: Initialize all members in skb_gro_remcsum_init() | From | David Miller <> |
| |
From: Geert Uytterhoeven <geert@linux-m68k.org> Date: Wed, 18 Feb 2015 11:38:06 +0100
> skb_gro_remcsum_init() initializes the gro_remcsum.delta member only, > leading to compiler warnings about a possibly uninitialized > gro_remcsum.offset member: > > drivers/net/vxlan.c: In function ‘vxlan_gro_receive’: > drivers/net/vxlan.c:602: warning: ‘grc.offset’ may be used uninitialized in this function > net/ipv4/fou.c: In function ‘gue_gro_receive’: > net/ipv4/fou.c:262: warning: ‘grc.offset’ may be used uninitialized in this function > > While these are harmless for now: > - skb_gro_remcsum_process() sets offset before changing delta, > - skb_gro_remcsum_cleanup() checks if delta is non-zero before > accessing offset, > it's safer to let the initialization function initialize all members. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied, thank you.
| |