Messages in this thread | | | Date | Fri, 20 Feb 2015 19:51:03 +0100 (CET) | From | Fabian Frederick <> | Subject | Re: [PATCH 6/7 linux-next] wan: cosa: replace current->state by set_current_state() |
| |
> On 20 February 2015 at 19:34 Sergei Shtylyov > <sergei.shtylyov@cogentembedded.com> wrote: > > > Hello. > > On 02/20/2015 09:12 PM, Fabian Frederick wrote: > > > Use helper functions to access current->state. > > Direct assignments are prone to races and therefore buggy. > > > current->state = TASK_RUNNING is replaced by __set_current_state() > > You sometimes use __set_current_state() and sometimes set_current_state(). Hello Sergei,
Peter suggested to use __set_current_state() for TASK_RUNNING : http://marc.info/?l=linux-kernel&m=142442259719216&w=2
Regards, Fabian
> > > Thanks to Peter Zijlstra for the exact definition of the problem. > > > Suggested-By: Peter Zijlstra <peterz@infradead.org> > > Signed-off-by: Fabian Frederick <fabf@skynet.be> > > [...] > > WBR, Sergei >
| |