lkml.org 
[lkml]   [2015]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/7] input: Add keycodes used by Lenovo Carbon X1 2014
On Fri, Feb 20, 2015 at 10:04:04AM -0500, Benjamin Tissoires wrote:
> On Fri, Feb 20, 2015 at 9:44 AM, Bastien Nocera <hadess@hadess.net> wrote:
> > Signed-off-by: Bastien Nocera <hadess@hadess.net>
> > ---
> > include/uapi/linux/input.h | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
> > index b0a8130..affe40e 100644
> > --- a/include/uapi/linux/input.h
> > +++ b/include/uapi/linux/input.h
> > @@ -740,6 +740,16 @@ struct input_keymap_entry {
> > #define KEY_BRIGHTNESS_MIN 0x250 /* Set Brightness to Minimum */
> > #define KEY_BRIGHTNESS_MAX 0x251 /* Set Brightness to Maximum */
> >
> > +#define KEY_CLIPPING_TOOL 0x252 /* Screenshot clipping tool */

Do we have users for this?

> > +#define KEY_CLOUD 0x253 /* Cloud Settings */

Just no. What is cloud settings? Use KEY_VENDOR if you must for this vendor
"added value" junk they come up on keyboards year after year. It used to be
WWW, not cloud, I bet in 2016 someone will come up with "IoT"-dedicated key.

> > +#define KEY_CAMERA_GESTURES 0x254 /* Toggle Camera gestures */
> > +#define KEY_NEW_TAB 0x255 /* Open a new tab */
> > +#define KEY_MICUP 0x256 /* Microphone Up */
> > +#define KEY_MICDOWN 0x257 /* Microphone Down */
> > +#define KEY_MICCANCEL_MODE 0x258 /* Toggle Microphone cancellation mode */
> > +#define KEY_CAMERA_ZOOM_MODE 0x259 /* Toggle camera zoom mode */
> > +#define KEY_ROTATE_DISPLAY 0x25a /* Rotate screen by 90 degrees */
> > +
>
> This one should be acked by Dmitry (in CC)
>

Some of these (like microphone volume up/down) are generic and reasonable, but
I need to know if there will be any users for these newly defined keys.

Thanks.

--
Dmitry


\
 
 \ /
  Last update: 2015-02-20 20:01    [W:0.038 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site