Messages in this thread | | | Date | Mon, 2 Feb 2015 16:34:31 +0100 | From | Peter Zijlstra <> | Subject | Re: Linux 3.19-rc5 |
| |
On Sun, Feb 01, 2015 at 12:09:32PM -0800, Linus Torvalds wrote: > Now, I have the patch that removes that thing (but I was hoping to get > it from the scheduler tree before doing rc7, which seems to not have > happened), but yes, that together with your patch seems like it should > fix all the nasty bug-inducing crud where the "debugging helpers" end > up silently changing core process state. > > I'll just combine it with yours to avoid extra noise in this area, and > mark you as the author, fixing *both* of the incorrect state changes. > Ok?
Ah I see it in your tree; I was about to suggest:
-# define sched_annotate_sleep() __set_current_state(TASK_RUNNING) +# define sched_annotate_sleep() do { current->task_state_change = 0; } while (0)
Instead of the assignment, which has a rvalue.
| |