Messages in this thread | | | Date | Mon, 2 Feb 2015 15:19:42 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH] posix_acl: fix reference leaks in posix_acl_create |
| |
On Sun, Feb 01, 2015 at 11:55:02PM -0800, Omar Sandoval wrote: > There are already a couple of return paths in posix_acl_create, and > there are only these two error cases, so I think gotos might actually > make the code more confusing. In any case, here's an idea: > > posix_acl: fix reference leaks in posix_acl_create > > get_acl gets a reference which we must release in the error cases. > > Signed-off-by: Omar Sandoval <osandov@osandov.com>
Thanks, this one looks good to me.
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |