lkml.org 
[lkml]   [2015]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] posix_acl: fix reference leaks in posix_acl_create
On Sun, Feb 01, 2015 at 11:55:02PM -0800, Omar Sandoval wrote:
> There are already a couple of return paths in posix_acl_create, and
> there are only these two error cases, so I think gotos might actually
> make the code more confusing. In any case, here's an idea:
>
> posix_acl: fix reference leaks in posix_acl_create
>
> get_acl gets a reference which we must release in the error cases.
>
> Signed-off-by: Omar Sandoval <osandov@osandov.com>

Thanks, this one looks good to me.

Reviewed-by: Christoph Hellwig <hch@lst.de>


\
 
 \ /
  Last update: 2015-02-02 15:41    [W:0.182 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site