lkml.org 
[lkml]   [2015]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] mtd: avoid registering reboot notifier twice

> On 02/02/2015 12:07 AM, Brian Norris wrote:
> >
> > No driver should be calling mtd_device_parse_register() multiple times
> > on the same mtd_info. Under what context do you see this? What driver?
> arch/cris/arch-v32/drivers/axisflashmap.c

Looking at it another way, why should it not be allowed, if the only
thing stopping it from working is Niklas' fix below? If there are multiple
ways a driver can acquire partitioning information, it is handy to be able
to do mtd_device_parse_register() several times, rather than collecting
all the partitioning information in one place and doing the call there,
which I suppose would be the alternative.

I've noted that mtd/nand/diskonchip.c does it too:

mtd_device_register(mtd, NULL, 0);
if (!no_autopart)
mtd_device_register(mtd, parts, numparts);

but this driver might be essentially deprecated, I don't know.

> >> Signed-off-by: Niklas Cassel <nks@flawful.org>
> >> ---
> >> drivers/mtd/mtdcore.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> >> index de79576..98efc1e 100644
> >> --- a/drivers/mtd/mtdcore.c
> >> +++ b/drivers/mtd/mtdcore.c
> >> @@ -556,7 +556,7 @@ int mtd_device_parse_register(struct mtd_info *mtd, const char * const *types,
> >> err = -ENODEV;
> >> }
> >>
> >> - if (mtd->_reboot) {
> >> + if (mtd->_reboot && !mtd->reboot_notifier.notifier_call) {
> >> mtd->reboot_notifier.notifier_call = mtd_reboot_notifier;
> >> register_reboot_notifier(&mtd->reboot_notifier);
> >> }

/Ricard
--
Ricard Wolf Wanderlöf ricardw(at)axis.com
Axis Communications AB, Lund, Sweden www.axis.com
Phone +46 46 272 2016 Fax +46 46 13 61 30


\
 
 \ /
  Last update: 2015-02-02 10:41    [W:0.062 / U:0.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site