lkml.org 
[lkml]   [2015]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/intel/quark: fix simple_return.cocci warnings
On 19/02/15 10:33, Ingo Molnar wrote:

>> Feedback at review was that it's more consistent with the
>> code that comes before.
>
> But that feedback makes very little sense. In C we don't
> ever want to write:
>
> if (ret)
> return ret;
>
> return 0;
>
> Because we can return the fine value straight away:
>
> return ret;
>
> regardless of what comes before.

:)

Just trying to accommodate as much feedback from people as possible.

I'm fine with the change and I'll let Andy argue the counter-point if he
wants to.

--
Bryan




\
 
 \ /
  Last update: 2015-02-19 12:21    [W:0.083 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site