Messages in this thread | | | Date | Thu, 19 Feb 2015 10:11:34 +0000 | From | Bryan O'Donoghue <> | Subject | Re: [PATCH] x86/intel/quark: fix simple_return.cocci warnings |
| |
On 19/02/15 08:14, kbuild test robot wrote: > arch/x86/platform/intel-quark/imr.c:129:1-4: WARNING: end returns can be simpified > > Simplify a trivial if-return sequence. Possibly combine with a > preceding function call. > Generated by: scripts/coccinelle/misc/simple_return.cocci > > CC: Bryan O'Donoghue <pure.logic@nexus-software.ie> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > --- > > imr.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > --- a/arch/x86/platform/intel-quark/imr.c > +++ b/arch/x86/platform/intel-quark/imr.c > @@ -126,12 +126,8 @@ static int imr_read(struct imr_device *i > if (ret) > return ret; > > - ret = iosf_mbi_read(QRK_MBI_UNIT_MM, QRK_MBI_MM_READ, > + return iosf_mbi_read(QRK_MBI_UNIT_MM, QRK_MBI_MM_READ, > reg++, &imr->wmask); > - if (ret) > - return ret; > - > - return 0; > } > > /** >
This flow was a change asked for and supplied in review feedback for Andy Shevchenko so NAK to this patch.
| |