lkml.org 
[lkml]   [2015]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] perf bench: fix order of arguments to memcpy_alloc_mem

* Bruce Merry <bmerry@ska.ac.za> wrote:

> This was causing the destination instead of the source to be filled.
> As a result, the source was typically all mapped to one zero page,
> and hence very cacheable.
>
> Signed-off-by: Bruce Merry <bmerry@ska.ac.za>
> ---
> tools/perf/bench/mem-memcpy.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/bench/mem-memcpy.c b/tools/perf/bench/mem-memcpy.c
> index 6c14afe..db1d3a2 100644
> --- a/tools/perf/bench/mem-memcpy.c
> +++ b/tools/perf/bench/mem-memcpy.c
> @@ -289,7 +289,7 @@ static u64 do_memcpy_cycle(const struct routine *r, size_t len, bool prefault)
> memcpy_t fn = r->fn.memcpy;
> int i;
>
> - memcpy_alloc_mem(&src, &dst, len);
> + memcpy_alloc_mem(&dst, &src, len);
>
> if (prefault)
> fn(dst, src, len);
> @@ -312,7 +312,7 @@ static double do_memcpy_gettimeofday(const struct routine *r, size_t len,
> void *src = NULL, *dst = NULL;
> int i;
>
> - memcpy_alloc_mem(&src, &dst, len);
> + memcpy_alloc_mem(&dst, &src, len);
>
> if (prefault)
> fn(dst, src, len);

Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

Ingo


\
 
 \ /
  Last update: 2015-02-19 01:41    [W:0.107 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site