lkml.org 
[lkml]   [2015]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 6/7] x86, mm: Support huge I/O mappings on x86

* Toshi Kani <toshi.kani@hp.com> wrote:

> This patch implements huge I/O mapping capability interfaces on x86.

> +#ifdef CONFIG_HUGE_IOMAP
> +#ifdef CONFIG_X86_64
> +#define IOREMAP_MAX_ORDER (PUD_SHIFT)
> +#else
> +#define IOREMAP_MAX_ORDER (PMD_SHIFT)
> +#endif
> +#endif /* CONFIG_HUGE_IOMAP */

> +#ifdef CONFIG_HUGE_IOMAP

Hm, so why is there a Kconfig option for this? It just
complicates things.

For example the kernel already defaults to mapping itself
with as large mappings as possible, without a Kconfig entry
for it. There's no reason to make this configurable - and
quite a bit of complexity in the patches comes from this
configurability.

Thanks,

Ingo


\
 
 \ /
  Last update: 2015-02-18 22:01    [W:0.124 / U:0.812 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site