Messages in this thread | | | Date | Wed, 18 Feb 2015 19:26:19 +0530 | From | Sudip Mukherjee <> | Subject | Re: [PATCH 4/5] fs: efs: fix possible memory leak |
| |
On Tue, Feb 17, 2015 at 07:31:01PM +0000, Al Viro wrote: > On Thu, Feb 12, 2015 at 02:32:21PM +0530, Sudip Mukherjee wrote: > > The hell we are not - unlike ->put_super(), ->kill_sb() is *always* > called, even when fill_super() fails halfway through. Exactly because > it makes for simpler cleanup requirements on failure exits in said > fill_super(). And we have > static void efs_kill_sb(struct super_block *s) > { > struct efs_sb_info *sbi = SUPER_INFO(s); > kill_block_super(s); > kfree(sbi); > } > for ->kill_sb() there, so sbi will *not* leak. thanks for explaining this. I was seeing the code in the fat and was trying to figure out why this in efs was not released. i was have one more doubt about efs_iget() but that also is actually cleared with this.
thanks sudip
> > NAK. This patch not only complicates efs_fill_super() for no good reason, > it ends up with double kfree() on those failure exits - ->s_fs_info is > left pointing to freed memory and efs_kill_sb() does kfree() again.
| |