Messages in this thread | | | Date | Wed, 18 Feb 2015 13:08:26 +0100 | From | Thierry Reding <> | Subject | Re: [PATCH 0/1] fix for pwm-mxs period divider computation |
| |
On Wed, Feb 18, 2015 at 09:18:55AM +0100, Gaetan Hug wrote: > Hello Thierry, > > I found a bug in the pwm-mxs.c driver for the i.MX28 platform. > > The driver computes from the desired period which clock divider it > should be using. This computation assumes that the link between the > register value and the actual divider value is raising 2 to the power of > the registry value. > > div = 1 << regvalue > > This is true only for the first 5 values out of 8. Next values are > 64, 256 and, 1024. > This affects only the user only if he requests a period > 0.04369s.
Can you put this description into the commit message of the proper patch, please?
Also, the subject should be in the following format:
pwm: mxs: Fix period divider computation
Thanks, Thierry [unhandled content-type:application/pgp-signature] | |