lkml.org 
[lkml]   [2015]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] Fix mcelog regression

* Luck, Tony <tony.luck@intel.com> wrote:

> Sorry for bypassing normal channels, but this looks like
> a trivial regression fix to me, but I'm getting pushback
> from my co-maintainer and from Ingo.
>
> 1. This used to work
> 2. Now it doesn't
> 3. People have complained
>
> Previous threads:
> https://lkml.org/lkml/2015/1/30/641
> https://lkml.org/lkml/2015/2/11/437

So this fix is perfectly OK to me. The primary thing I
objected to (which objection you did not quote!!), was the
initial approach, the ugly vendor-specific switch you
added:

https://lkml.org/lkml/2015/2/9/237

The latest replacement commit you added looks clean - and
/dev/mcelog is certainly a legacy we have to keep.

Thanks,

Ingo


\
 
 \ /
  Last update: 2015-02-18 08:01    [W:2.348 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site