lkml.org 
[lkml]   [2015]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/11] ARM: berlin: rework chip and system controller nodes for BG2
On 11.02.2015 17:15, Antoine Tenart wrote:
> The chip and system controller nodes are now handled by the Berlin
> controller mfd driver. Its sub-devices are then registered by the mfd
> driver and let the drivers be probed properly, using their own
> sub-nodes.
>
> Rework the device tree to take this changes into account.
>
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
[...]
> - chip: chip-control@ea0000 {
> - compatible = "marvell,berlin2-chip-ctrl";
> - #clock-cells = <1>;
> - #reset-cells = <2>;
> + chip: chip-controller@ea0000 {
> + compatible = "marvell,berlin2-chip-ctrl", "syscon";
> reg = <0xea0000 0x400>;
> + #clock-cells = <1>;

Antoine,

I noticed just now, but we should either have all of clock, reset,
pinctrl as sub-nodes or none. Currently, this has pinctrl and reset
as sub-nodes but clock hooked up to chip-controller.

Sebastian

> clocks = <&refclk>;
> clock-names = "refclk";
>
> - emmc_pmux: emmc-pmux {
> - groups = "G26";
> - function = "emmc";
> + soc_pinctrl: pin-controller {
> + compatible = "marvell,berlin2-soc-pinctrl";
> +
> + emmc_pmux: emmc-pmux {
> + groups = "G26";
> + function = "emmc";
> + };
> + };
> +
> + chip_rst: reset {
> + compatible = "marvell,berlin2-reset";
> + #reset-cells = <2>;
> };
> };
>
> @@ -442,22 +450,26 @@
> };
>
> sysctrl: system-controller@d000 {
> - compatible = "marvell,berlin2-system-ctrl";
> + compatible = "marvell,berlin2-system-ctrl", "syscon";
> reg = <0xd000 0x100>;
>
> - uart0_pmux: uart0-pmux {
> - groups = "GSM4";
> - function = "uart0";
> - };
> + sys_pinctrl: pin-controller {
> + compatible = "marvell,berlin2-system-pinctrl";
>
> - uart1_pmux: uart1-pmux {
> - groups = "GSM5";
> - function = "uart1";
> - };
> + uart0_pmux: uart0-pmux {
> + groups = "GSM4";
> + function = "uart0";
> + };
> +
> + uart1_pmux: uart1-pmux {
> + groups = "GSM5";
> + function = "uart1";
> + };
>
> - uart2_pmux: uart2-pmux {
> - groups = "GSM3";
> - function = "uart2";
> + uart2_pmux: uart2-pmux {
> + groups = "GSM3";
> + function = "uart2";
> + };
> };
> };
>
>



\
 
 \ /
  Last update: 2015-02-18 11:41    [W:0.117 / U:1.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site