lkml.org 
[lkml]   [2015]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] ocfs2: remove useless if statement
On Tue, 17 Feb 2015 16:13:50 +0900 Daeseok Youn <daeseok.youn@gmail.com> wrote:

> The Local variable "i" in for loop is always less then
> O2CB_MAP_STABILIZE_COUNT.
>
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> ---
> fs/ocfs2/stack_o2cb.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ocfs2/stack_o2cb.c b/fs/ocfs2/stack_o2cb.c
> index 1724d43..813d726 100644
> --- a/fs/ocfs2/stack_o2cb.c
> +++ b/fs/ocfs2/stack_o2cb.c
> @@ -295,8 +295,8 @@ static int o2cb_cluster_check(void)
> set_bit(node_num, netmap);
> if (!memcmp(hbmap, netmap, sizeof(hbmap)))
> return 0;
> - if (i < O2CB_MAP_STABILIZE_COUNT)
> - msleep(1000);
> +
> + msleep(1000);
> }

I assume the code was intended to do

if (i < O2CB_MAP_STABILIZE_COUNT - 1)
msleep(1000);

to avoid a pointless 1-second delay when the operation times out.


\
 
 \ /
  Last update: 2015-02-18 00:41    [W:0.028 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site