lkml.org 
[lkml]   [2015]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ipc: Remove uses of return value of seq_printf/seq_puts
From
Date
On Tue, 2015-02-17 at 14:52 -0800, Andrew Morton wrote:
> On Tue, 17 Feb 2015 11:44:48 -0800 Joe Perches <joe@perches.com> wrote:
>
> > These functions are soon going to return void
>
> That's news to me.

https://lkml.org/lkml/2014/11/4/393

> > so remove the
> > return value uses.
> >
> > Convert the return value to test seq_has_overflowed() instead.
>
> Why not make seq_printf() return seq_has_overflowed()?

Unnecessary overhead.

> I'm sure it's all very sensible, but the changelogging is poor. Perhaps
> doing all this in a coherent patch series would be a better way.

The changes span too many subsystems.

These could just return 0 for the most part.



\
 
 \ /
  Last update: 2015-02-18 00:21    [W:2.688 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site