lkml.org 
[lkml]   [2015]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH/RFC 2/2] regulator: da9210: Add optional interrupt support
On Tue, Feb 17, 2015 at 01:11:12PM +0100, Geert Uytterhoeven wrote:

> - Does there exist any regulator notifier event that corresponds to
> DA9210_E_VMAX?

What does that mean, I might be able to tell you? I guess it might be
an over voltage event...

> + error = regmap_read(chip->regmap, DA9210_REG_EVENT_B, &val);
> + if (error < 0)
> + goto error_i2c;

...

> + if (val) {
> + /* Clear all events */
> + error = regmap_write(chip->regmap, DA9210_REG_EVENT_B, val);
> + if (error < 0)
> + goto error_i2c;
> +
> + ret = IRQ_HANDLED;
> + }

It's generally better to only acknowledge unmasked sources for
defensiveness and improved diagnostics. Not super critical though.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-02-17 15:21    [W:0.056 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site