lkml.org 
[lkml]   [2015]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 067/122] kconfig: Fix warning \" ‘jump’ may be used uninitialized\"
    Date
    From: Peter Kümmel <syntheticpp@gmx.net>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    commit 2d560306096739e2251329ab5c16059311a151b0 upstream.

    Warning:
    In file included from scripts/kconfig/zconf.tab.c:2537:0:
    scripts/kconfig/menu.c: In function ‘get_symbol_str’:
    scripts/kconfig/menu.c:590:18: warning: ‘jump’ may be used uninitialized in this function [-Wmaybe-uninitialized]
    jump->offset = strlen(r->s);

    Simplifies the test logic because (head && local) means (jump != 0)
    and makes GCC happy when checking if the jump pointer was initialized.

    Signed-off-by: Peter Kümmel <syntheticpp@gmx.net>
    Signed-off-by: Michal Marek <mmarek@suse.cz>
    Cc: Sedat Dilek <sedat.dilek@gmail.com>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    scripts/kconfig/menu.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
    index 2b3317010ba4..c81f055343b7 100644
    --- a/scripts/kconfig/menu.c
    +++ b/scripts/kconfig/menu.c
    @@ -544,7 +544,7 @@ static void get_prompt_str(struct gstr *r, struct property *prop,
    {
    int i, j;
    struct menu *submenu[8], *menu, *location = NULL;
    - struct jump_key *jump;
    + struct jump_key *jump = NULL;

    str_printf(r, _("Prompt: %s\n"), _(prop->text));
    menu = prop->menu->parent;
    @@ -582,7 +582,7 @@ static void get_prompt_str(struct gstr *r, struct property *prop,
    str_printf(r, _(" Location:\n"));
    for (j = 4; --i >= 0; j += 2) {
    menu = submenu[i];
    - if (head && location && menu == location)
    + if (jump && menu == location)
    jump->offset = strlen(r->s);
    str_printf(r, "%*c-> %s", j, ' ',
    _(menu_get_prompt(menu)));
    --
    2.2.2


    \
     
     \ /
      Last update: 2015-02-17 13:21    [W:4.137 / U:0.840 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site