lkml.org 
[lkml]   [2015]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/2] dgnc: Remove superfluous EXTRA_CFLAGS variable
On Sun, Feb 15, 2015 at 11:40:17PM +0000, Cass May wrote:
> Clean up Makefile by removing unnecessary definition of DG_NAME.
>
> Signed-off-by: Cass May <cass@cassm.net>
> ---
> Having done some build tests, it seems that DG_NAME is not needed,
> but DG_PART is referenced in dgnc_mgmt.c. I have removed the former,
> and moved the latter into the appropriate header.

Thanks!

Don't resend; this patch is great. But next time just fold both patches
together into one patch. It's all part of the same fix really so it
falls into the "one thing per patch" rule.

regards,
dan carpenter



\
 
 \ /
  Last update: 2015-02-16 10:21    [W:0.063 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site