Messages in this thread | | | Date | Tue, 17 Feb 2015 08:58:47 +0900 | From | Chanwoo Choi <> | Subject | Re: [PATCH 1/2] extcon: arizona: Deobfuscate arizona_extcon_do_magic |
| |
Hi Charles,
On 02/17/2015 01:48 AM, Chanwoo Choi wrote: > Hi Charles, > > > On Tue, Feb 17, 2015 at 12:41 AM, Charles Keepax > <ckeepax@opensource.wolfsonmicro.com> wrote: >> arizona_extcon_do_magic does not lend a lot of clarity to the purpose >> of the function, and as all the registers used are described in the >> datasheet there is no need to obfuscate the code. This patch renames the >> function to arizona_extcon_hp_clamp, as it controls clamping on the >> headphone output. >> >> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> >> --- >> drivers/extcon/extcon-arizona.c | 36 ++++++++++++++++++++---------------- >> include/linux/mfd/arizona/core.h | 2 +- >> sound/soc/codecs/arizona.c | 4 ++-- >> 3 files changed, 23 insertions(+), 19 deletions(-) > > > Looks good to me. > But, you need more ack message by MFD maintainer. > > For extcon part: > Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Applied it.
Thanks, Chanwoo Choi
| |