lkml.org 
[lkml]   [2015]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] mm: cma: add currently allocated CMA buffers list to debugfs
Hello SeongJae,

On 13/02/15 17:18, SeongJae Park wrote:
> Hello, Stefan.
>
> On Fri, 13 Feb 2015, Stefan Strogin wrote:
>
>> #include <linux/io.h>
>> +#include <linux/list.h>
>> +#include <linux/proc_fs.h>
>> +#include <linux/time.h>
>
> Looks like `proc_fs.h` and `time.h` are not necessary.
>

Yes, of course. Thanks.


>> + pr_warn("%s(page %p, count %d): failed to allocate buffer
>> list entry\n",
>> + __func__, pfn_to_page(pfn), count);
>
> pfn_to_page() would cause build failure on x86_64. Why don't you include
> appropriate header file?
>

Indeed. Because I tested it only on arm and x86. Sorry :( Thank you.



\
 
 \ /
  Last update: 2015-02-16 20:41    [W:0.061 / U:12.604 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site