lkml.org 
[lkml]   [2015]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] ARM: smp: Only expose /sys/.../cpuX/online if hotpluggable
On Fri, Feb 13, 2015 at 11:01:37PM +0000, Russell King - ARM Linux wrote:
> On Fri, Feb 13, 2015 at 09:44:50PM +0000, Magnus Damm wrote:
> > Also, based on the comment in mcpm_cpu_can_disable() it looks like the
> > PSCI hook may be executed once only with your change in place?
> > Hopefully PSCI is OK not being invoked for every CPU shutdown.
>
> This is why I've said (in the parent thread) that I'm not happy to
> apply this patch. Mark Rutland has indicated that he has MCPM cases
> where the CPUs which can be disabled changes dynamically according
> to the secure firmware requirements, and ripping out todays
> infrastructure in light of that, only to have to add it back again
> later makes no sense.

To clarify, PSCI and MCPM are unrelated. It was originally conceived
that MCPM would use PSCI as a backend, but it turns out that they're
effectively mutually exclusive, and are handled separately. I still want
to add support for MIGRATE in the PSCI client code, but this is
independent of MCPM.

In some cases it's possible to determine at boot time that a CPU cannot
be hotplugged (e.g. in PSCI if the TOS is non-migrateable), so having
separate hooks for determining that static and dynamic ability to
hotplug a CPU sounds reasonable to me.

Thanks,
Mark.


\
 
 \ /
  Last update: 2015-02-16 16:41    [W:0.081 / U:11.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site