lkml.org 
[lkml]   [2015]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/6] mfd: max77843: Add max77843 MFD driver core driver
On Wed, 04 Feb 2015, Chanwoo Choi wrote:
> On 02/04/2015 01:56 PM, Jaewon Kim wrote:
> > This patch adds MAX77843 core/irq driver to support PMIC,
> > MUIC(Micro USB Interface Controller), Charger, Fuel Gauge,
> > LED and Haptic device.
> >
> > Cc: Lee Jones <lee.jones@linaro.org>
> > Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> > Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
> > ---
> > drivers/mfd/Kconfig | 14 ++
> > drivers/mfd/Makefile | 1 +
> > drivers/mfd/max77843.c | 245 +++++++++++++++++++
> > include/linux/mfd/max77843-private.h | 441 ++++++++++++++++++++++++++++++++++
> > 4 files changed, 701 insertions(+)
> > create mode 100644 drivers/mfd/max77843.c
> > create mode 100644 include/linux/mfd/max77843-private.h

<LOTS OF POINTLESS LINES OF UNCHANGED/UNREVIEWED CODE>

> Looks good to me.
>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

Chanwoo,

If you're not going to make any comments, either put the Reviewed-by
at the top, or better still, snip out all of the bumph in the middle.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog


\
 
 \ /
  Last update: 2015-02-16 15:01    [W:0.169 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site