lkml.org 
[lkml]   [2015]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 0/6] Drivers: hv: vmbus
Date
> -----Original Message-----
> From: devel [mailto:driverdev-devel-bounces@linuxdriverproject.org] On Behalf
> Of K. Y. Srinivasan
> Sent: Monday, February 16, 2015 4:11 AM
> To: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> vkuznets@redhat.com
> Subject: [PATCH 0/6] Drivers: hv: vmbus
>
> The host can rescind an offer any time after the offer has been made
> to the guest. This patch-set cleans up how we handle rescind messages
> from the host.
>
>
> K. Y. Srinivasan (6):
> Drivers: hv: vmbus: Properly handle child device remove
> Drivers: hv: vmbus: Introduce a function to remove a rescinded offer
> Drivers: hv: vmbus: Handle both rescind and offer messages in the
> same context
> Drivers: hv: vmbus: Remove the channel from the channel list(s) on
> failure
> Drivers: hv: util: On device remove, close the channel after
> de-initializing the service
> Drivers: hv: vmbus: Get rid of some unnecessary messages
>
> drivers/hv/channel.c | 9 ++++
> drivers/hv/channel_mgmt.c | 95 ++++++++++++++++++++------------------------
> drivers/hv/connection.c | 7 +---
> drivers/hv/hv_util.c | 2 +-
> drivers/hv/vmbus_drv.c | 26 +++++++++---
> include/linux/hyperv.h | 1 +
> 6 files changed, 74 insertions(+), 66 deletions(-)
>
> --

The patchset seems good to me.
Reviewed-by: Dexuan Cui <decui@microsoft.com>

BTW, IMO we need one more patch to remove the queue_work() in
free_channel() -- just make it an ordinary synchronous function call:

vmbus_process_offer() can invoke free_channel() on error path,
and vmbus_process_rescind() can invoke free_channel() too.
We should exclude the possible race.

And now the controlwq and work fields of struct vmbus_channel
are useless now.

Thanks,
-- Dexuan



\
 
 \ /
  Last update: 2015-02-16 04:41    [W:0.081 / U:0.920 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site