lkml.org 
[lkml]   [2015]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Don't leak a key reference if request_key() tries to use a revoked keyring
On Thu, 12 Feb 2015, David Howells wrote:

> From: David Jeffery <djeffery@redhat.com>
>
> If a request_key() call to allocate and fill out a key attempts to insert the
> key structure into a revoked keyring, the key will leak, using memory and part
> of the user's key quota until the system reboots. This is from a failure of
> construct_alloc_key() to decrement the key's reference count after the attempt
> to insert into the requested keyring is rejected.
>
> key_put() needs to be called in the link_prealloc_failed callpath to ensure
> the unused key is released.
>
> Signed-off-by: David Jeffery <djeffery@redhat.com>
> Signed-off-by: David Howells <dhowells@redhat.com>

Applied.


--
James Morris
<jmorris@namei.org>



\
 
 \ /
  Last update: 2015-02-16 03:41    [W:0.034 / U:8.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site