lkml.org 
[lkml]   [2015]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] hwrng: iproc-rng200 - Add Broadcom IPROC RNG driver
I didn't read this properly.  Will add \n in the dev_err messages.

Thanks,
Scott

On 15-02-14 08:36 AM, Scott Branden wrote:
> Hi Joe,
>
> I really don't see the missing terminating newlines in the patch or
> source code. The lines look the same as every other line???
>
> Regards,
> Scott
>
> On 15-02-09 04:27 PM, Joe Perches wrote:
>> On Mon, 2015-02-09 at 16:07 -0800, Scott Branden wrote:
>>> This adds a driver for random number generator present on Broadcom
>>> IPROC devices.
>>
>> trivia:
>>
>>> diff --git a/drivers/char/hw_random/iproc-rng200.c
>>> b/drivers/char/hw_random/iproc-rng200.c
>> []
>>> +static int iproc_rng200_probe(struct platform_device *pdev)
>>> +{
>> []
>>> + if (!res) {
>>> + dev_err(dev, "failed to get rng resources");
>>
>> Missing terminating newline:
>>
>> dev_err(dev, "failed to get rng resources\n");
>>
>>> + rng_base = devm_ioremap_resource(dev, res);
>>> + if (!rng_base) {
>>> + dev_err(dev, "failed to remap rng regs");
>>
>> here too.
>>
>>
>



\
 
 \ /
  Last update: 2015-02-14 18:21    [W:0.044 / U:23.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site