Messages in this thread | | | Date | Fri, 13 Feb 2015 13:36:18 +0000 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH 2/2]Trivial patch: to solve indentation warnings in amba-clcd.c driver |
| |
On Fri, Feb 13, 2015 at 08:28:10AM -0500, Parmeshwr Prasad wrote: > > This is second patch in series. > In driver in_atomic we should not use to check if code is unning in IRQ. > clcdfb_sleep() function is used to give some delay between operation. > I have used schedule_timeout() function for same amount of delay.
Frankly, this patch is a mess. It seems to contain unrelated changes.
Please always review your own patches before you send them - this will allow you to catch such errors before you post them publically.
The change to clcdfb_sleep() is wrong in any case - you will end up calling schedule_timeout() from illegal contexts (eg, when the framebuffer gets blanked/unblanked.)
-- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net.
| |