Messages in this thread |  | | Date | Fri, 13 Feb 2015 12:03:19 +0000 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH 1/2]Trivial patch: to solve indentation warnings in amba-clcd.c driver |
| |
On Fri, Feb 13, 2015 at 03:59:56AM -0800, Joe Perches wrote: > Perhaps this could be better as: > > fb->fb.fix.smem_start = > of_translate_address(memory, > of_get_address(memory, 0, &size, NULL)); > > But sometimes using multiple statements instead of > embedding function calls as arguments can be simpler > and more intelligible for the reader. > > __be32 addr; > > ... > > addr = of_get_address(memory, 0, &size, NULL); > fb->fb.fix.smem_start = of_translate_address(memory, addr);
Yes, that would be a better solution, thanks.
-- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net.
|  |