lkml.org 
[lkml]   [2015]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/6] staging: rtl8188eu: hal: removed code indent error
On Tue, Feb 10, 2015 at 03:27:11PM +0100, Bas Peters wrote:
> >> @@ -101,8 +101,7 @@ void rtl88eu_phy_rf6052_set_cck_txpower(struct adapter *adapt, u8 *powerlevel)
> >> ptr++;
> >> }
> >> }
> >> - rtl88eu_dm_txpower_track_adjust(&hal_data->odmpriv, 1, &direction,
> >> - &pwrtrac_value);
> >> + rtl88eu_dm_txpower_track_adjust(&hal_data->odmpriv, 1, &direction, &pwrtrac_value);
> > you are introducing one warning to fix one error. line over 80 character.
>
> Isn't that warning more of a guideline, rather than an actual warning?

You can't fight checkpatch.pl. We reject the worst or the worst "break
lines up into smaller chunks" patches where they obviously hurt
readability, but we almost always silence the warning in the end. The
original code in this case was fine.

regards,
dan carpenter



\
 
 \ /
  Last update: 2015-02-11 09:41    [W:0.075 / U:14.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site