Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] module: Annotate nested sleep in resolve_symbol() | Date | Wed, 11 Feb 2015 10:18:34 +1030 |
| |
Dave Jones <davej@codemonkey.org.uk> writes: > On Tue, Feb 10, 2015 at 06:12:55PM +0100, Peter Zijlstra wrote: > > On which, we should probably do this. > > > > --- > > Subject: module: Replace over-engineered nested sleep > > > > Since the introduction of the nested sleep warning; we've established > > that the occasional sleep inside a wait_event() is fine. > > > > wait_event() loops are invariant wrt. spurious wakeups, and the > > occasional sleep has a similar effect on them. As long as its occasional > > its harmless. > > > > Therefore replace the 'correct' but verbose wait_woken() thing with > > a simple annotation to shut up the warning. > > > > Cc: Rusty Russell <rusty@rustcorp.com.au> > > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> > > Seems to suppress the warning, and modules still work. > > Tested-by: Dave Jones <davej@codemonkey.org.uk>
OK, applied.
Thanks! Rusty.
| |