lkml.org 
[lkml]   [2015]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] module: Annotate nested sleep in resolve_symbol()
Date
Dave Jones <davej@codemonkey.org.uk> writes:
> On Tue, Feb 10, 2015 at 06:12:55PM +0100, Peter Zijlstra wrote:
> > On which, we should probably do this.
> >
> > ---
> > Subject: module: Replace over-engineered nested sleep
> >
> > Since the introduction of the nested sleep warning; we've established
> > that the occasional sleep inside a wait_event() is fine.
> >
> > wait_event() loops are invariant wrt. spurious wakeups, and the
> > occasional sleep has a similar effect on them. As long as its occasional
> > its harmless.
> >
> > Therefore replace the 'correct' but verbose wait_woken() thing with
> > a simple annotation to shut up the warning.
> >
> > Cc: Rusty Russell <rusty@rustcorp.com.au>
> > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
>
> Seems to suppress the warning, and modules still work.
>
> Tested-by: Dave Jones <davej@codemonkey.org.uk>

OK, applied.

Thanks!
Rusty.


\
 
 \ /
  Last update: 2015-02-11 07:41    [W:0.057 / U:26.952 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site