lkml.org 
[lkml]   [2015]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [Patch 2/3] firmware: dmi_scan: fix dmi_len type
From
On 11 February 2015 at 17:46, Ivan Khoronzhuk
<ivan.khoronzhuk@linaro.org> wrote:
> According to SMBIOSv3 specification the length of DMI table can be
> up to 32bits wide. So use appropriate type to avoid overflow.
>
> It's obvious that dmi_num theoretically can be more than u16 also,
> so it's can be changed to u32 or at least it's better to use int
> instead of u16, but on that moment I cannot imagine dmi structure
> count more than 65535 and it can require changing type of vars that
> work with it. So I didn't correct it.
>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>

Acked-by: Ard Biesheuvel <ard@linaro.org>

This should get a cc stable as well.

--
Ard.

> ---
> drivers/firmware/dmi_scan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c
> index fb16203..952e95c 100644
> --- a/drivers/firmware/dmi_scan.c
> +++ b/drivers/firmware/dmi_scan.c
> @@ -18,7 +18,7 @@
> static const char dmi_empty_string[] = " ";
>
> static u16 __initdata dmi_ver;
> -static u16 dmi_len;
> +static u32 dmi_len;
> static u16 dmi_num;
> /*
> * Catch too early calls to dmi_check_system():
> --
> 1.9.1
>


\
 
 \ /
  Last update: 2015-02-11 11:01    [W:0.476 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site