Messages in this thread | | | Date | Tue, 10 Feb 2015 09:18:10 +0100 | From | Paolo Bonzini <> | Subject | Re: [PATCH 1/2] KVM: x86: extract guest running logic from __vcpu_run |
| |
On 09/02/2015 23:44, David Matlack wrote: >> > >> > +static inline int __vcpu_run(struct kvm *kvm, struct kvm_vcpu *vcpu) > Kind of confusing function body given the name. Maybe put > > if (vcpu->arch.mp_state == KVM_MP_STATE_RUNNABLE && > !vcpu->arch.apf.halted) > return vcpu_enter_guest(vcpu); > > back in vcpu_run and rename this function? vcpu_wait?
Yeah, vcpu_wait or vcpu_block (since it calls kvm_vcpu_block) sound good.
Paolo
| |