lkml.org 
[lkml]   [2015]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] rtlwifi: ratelimit skb allocation failure message
Date
Eric Dumazet <eric.dumazet@gmail.com> writes:

> On Tue, 2015-02-10 at 08:54 +0000, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> when running low on memory I noticed rtlwifi was producing a large
>> quantity of repeated skb allocation failures messages. This should
>> be ratelimited to reduce the noise.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/net/wireless/rtlwifi/pci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
>> index c70efb9..ca0fd50 100644
>> --- a/drivers/net/wireless/rtlwifi/pci.c
>> +++ b/drivers/net/wireless/rtlwifi/pci.c
>> @@ -817,7 +817,7 @@ static void _rtl_pci_rx_interrupt(struct ieee80211_hw *hw)
>> /* get a new skb - if fail, old one will be reused */
>> new_skb = dev_alloc_skb(rtlpci->rxbuffersize);
>> if (unlikely(!new_skb)) {
>> - pr_err("Allocation of new skb failed in %s\n",
>> + pr_err_ratelimited("Allocation of new skb failed in %s\n",
>> __func__);
>
> Or even better, remove the message.

There's actually a pending patch for that, I'll send it to Dave ASAP:

https://patchwork.kernel.org/patch/5671121/

--
Kalle Valo


\
 
 \ /
  Last update: 2015-02-10 15:21    [W:0.743 / U:0.788 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site