lkml.org 
[lkml]   [2015]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 08/11] ARM: STi: Register CPUFreq device
    On 09-12-15, 10:15, Arnd Bergmann wrote:
    > On Tuesday 08 December 2015 14:32:01 Lee Jones wrote:
    > > @@ -161,3 +166,11 @@ struct smp_operations __initdata sti_smp_ops = {
    > > .smp_secondary_init = sti_secondary_init,
    > > .smp_boot_secondary = sti_boot_secondary,
    > > };
    > > +
    > > +/**
    > > + * CPUFreq Registration
    > > + */
    > > +void init_cpufreq(void)
    > > +{
    > > + platform_device_register_simple("sti-cpufreq", -1, NULL, 0);
    > > +}
    > >
    >
    > Can you please do this under drivers/cpufreq somewhere?
    >
    > I really don't want to any more of these in platform code. Requiring a
    > device to be created just to probe the driver is really silly.

    He is actually creating two device right now..

    - create sti-cpufreq device
    - so that sti-cpufreq driver get probed
    - And fix OPPs here first and then create cpufreq-dt device
    - so that cpufreq-dt driver get probed

    :)

    I already recommended him that he can replace the first two points by
    doing things from module_init() instead. And then create cpufreq-dt
    device.

    --
    viresh


    \
     
     \ /
      Last update: 2015-12-09 10:41    [W:4.145 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site