Messages in this thread Patch in this message | | | From | Namhyung Kim <> | Subject | [PATCH 5/7] perf top: Delay UI browser setup after initialization is done | Date | Thu, 10 Dec 2015 12:00:57 +0900 |
| |
Move setup_browser after all necessary initialization is done. This is to remove the browser dependency from usage_with_options() and friends.
Cc: Josh Poimboeuf <jpoimboe@redhat.com> Signed-off-by: Namhyung Kim <namhyung@kernel.org> --- tools/perf/builtin-top.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index 7e2e72e6d9d1..75134e106a62 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c @@ -1252,13 +1252,6 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused) goto out_delete_evlist; } - if (top.use_stdio) - use_browser = 0; - else if (top.use_tui) - use_browser = 1; - - setup_browser(false); - status = target__validate(target); if (status) { target__strerror(target, status, errbuf, BUFSIZ); @@ -1326,6 +1319,13 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused) sigaction(SIGWINCH, &act, NULL); } + if (top.use_stdio) + use_browser = 0; + else if (top.use_tui) + use_browser = 1; + + setup_browser(false); + status = __cmd_top(&top); out_delete_evlist: -- 2.6.2
| |