lkml.org 
[lkml]   [2015]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 20/34] x86, pkeys: differentiate instruction fetches
On Thu, 3 Dec 2015, Dave Hansen wrote:
> static inline bool arch_vma_access_permitted(struct vm_area_struct *vma,
> - bool write, bool foreign)
> + bool write, bool execute, bool foreign)
....
> + /*
> + * gups are always data accesses, not instruction
> + * fetches, so execute=0 here

Again. Can we please be consistent about booleans?

> + */
> + if (!arch_vma_access_permitted(vma, write, 0, foreign))
> return -EFAULT;
> return 0;
> }
> @@ -576,8 +580,11 @@ bool vma_permits_fault(struct vm_area_st
> /*
> * The architecture might have a hardware protection
> * mechanism other than read/write that can deny access.
> + *
> + * gup always represents data access, not instruction
> + * fetches, so execute=0 here:
> */
> - if (!arch_vma_access_permitted(vma, write, foreign))
> + if (!arch_vma_access_permitted(vma, write, 0, foreign))
> return false;

Ditto.

Other than that: Reviewed-by: Thomas Gleixner <tglx@linutronix.de>


\
 
 \ /
  Last update: 2015-12-08 19:41    [W:0.374 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site