Messages in this thread | | | Subject | Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err() | From | Joe Perches <> | Date | Tue, 08 Dec 2015 09:03:51 -0800 |
| |
On Tue, 2015-12-08 at 08:16 -0800, Joe Perches wrote: > On Wed, 2015-12-09 at 01:07 +0900, Masahiro Yamada wrote: > > Trivial changes suggested by checkpatch.pl. > [] > > diff --git a/drivers/of/address.c b/drivers/of/address.c > [] > > @@ -23,7 +23,7 @@ static int __of_address_to_resource(struct device_node *dev, > > #ifdef DEBUG > > static void of_dump_addr(const char *s, const __be32 *addr, int na) > > { > > - printk(KERN_DEBUG "%s", s); > > + pr_debug("%s", s); > > while (na--) > > printk(" %08x", be32_to_cpu(*(addr++))); > > printk("\n"); > > mixing pr_debug and printk doesn't make much sense. > > It might be nicer to use > > static void of_dumpaddr(const char *s, const __be32 *addr, int na) > { > #ifdef DEBUG > ... > #endif > } > > to avoid the other static declaration
Or more simply:
static void of_dumpaddr(const char *s, const __be32 *addr, int na) { print_hex_dump_debug(s, DUMP_PREFIX_NONE, 16, 1, addr, na * sizeof(__be32), false); }
| |