lkml.org 
[lkml]   [2015]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 1/5] dma: do not use 0x in front of %pad
On Tue, Dec 01, 2015 at 10:01:52AM +0100, Nicolas Ferre wrote:
> Le 30/11/2015 21:45, Dmitry V. Krivenok a écrit :
> > Signed-off-by: Dmitry V. Krivenok <krivenok.dmitry@gmail.com>
>
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>
> > ---
> > drivers/dma/at_hdmac_regs.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h
> > index 7f58f06..0474e4a 100644
> > --- a/drivers/dma/at_hdmac_regs.h
> > +++ b/drivers/dma/at_hdmac_regs.h
> > @@ -385,7 +385,7 @@ static void vdbg_dump_regs(struct at_dma_chan *atchan) {}
> > static void atc_dump_lli(struct at_dma_chan *atchan, struct at_lli *lli)
> > {
> > dev_crit(chan2dev(&atchan->chan_common),
> > - " desc: s%pad d%pad ctrl0x%x:0x%x l0x%pad\n",
> > + " desc: s%pad d%pad ctrl0x%x:0x%x l%pad\n",
> > &lli->saddr, &lli->daddr,
> > lli->ctrla, lli->ctrlb, &lli->dscr);

Hi Vinod,

I think this ended up being misapplied, possibly because the patch
doesn't seem to have been based on something upstream. I got build
warnings during sanity builds of linux-next today and applied this
patch to fix them. Feel free to squash it into the original patch.

Thierry

--->8---
diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h
index 610907dbc11a..0474e4a0f02a 100644
--- a/drivers/dma/at_hdmac_regs.h
+++ b/drivers/dma/at_hdmac_regs.h
@@ -386,8 +386,8 @@ static void atc_dump_lli(struct at_dma_chan *atchan, struct at_lli *lli)
{
dev_crit(chan2dev(&atchan->chan_common),
" desc: s%pad d%pad ctrl0x%x:0x%x l%pad\n",
- lli->saddr, lli->daddr,
- lli->ctrla, lli->ctrlb, lli->dscr);
+ &lli->saddr, &lli->daddr,
+ lli->ctrla, lli->ctrlb, &lli->dscr);
}
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-12-08 16:01    [W:0.075 / U:0.968 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site