Messages in this thread | | | Date | Mon, 7 Dec 2015 11:54:13 -0800 | Subject | Re: [PATCH] time: verify time values in adjtimex ADJ_SETOFFSET to avoid overflow | From | John Stultz <> |
| |
On Sun, Dec 6, 2015 at 2:11 PM, Richard Cochran <richardcochran@gmail.com> wrote: > The overflow is a latent problem, and the patch should: > > 1. return error in case (txc->time.tv_usec >= USEC_PER_SEC) > 2. remove the redundant test in timekeeping_inject_offset.
So we probably want to keep the check in timekeeping_inject_offset() since there can be other users as well of that function.
But its probably cleanest to add a check in ntp_validate_timex() instead of where this patch does it.
thanks -john
(And thanks Thomas for taking a second look here)
| |